Changeset 55736 for branches/6.2/tests/phpunit/tests/dependencies/styles.php

Timestamp:

05/09/2023 12:15:44 PM (3 years ago)

Author:

audrasjb

Message:

Script Loader: Optimize performance of _wp_normalize_relative_css_links() by more than 2x.

• Replace preg_match_all() and its secondary str_replace() call with preg_replace_callback().
• Fix case where paths beginning with http and https (but not http: and https:) were erroneously not counted as relative.
• Improve code style and readability by consolidating conditions and returning once.
• Use str_starts_with() consistently instead of strpos().

Follow-up to [52036], [52695], and [52754].

Props westonruter, adamsilverstein, azaozz.
Merges [55658] and [55669] to the 6.2 branch.
Fixes #58069.
See #54243.

Location:

branches/6.2

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/dependencies/styles.php (modified) (2 diffs)

branches/6.2/tests/phpunit/tests/dependencies/styles.php

@@ -197 +197 @@
          * @ticket 54243
          * @ticket 54922
+         * @ticket 58069
          *
          * @covers ::_wp_normalize_relative_css_links
@@ -240 +241 @@
                                 'css'      => 'img {mask-image: url(\'data:image/svg+xml;utf8,<svg></svg>\');}',
                                 'expected' => 'img {mask-image: url(\'data:image/svg+xml;utf8,<svg></svg>\');}',
+                        ),
+                        'URLs with path beginning with http'           => array(
+                                'css'      => 'p {background:url( "http-is-awesome.png" );}',
+                                'expected' => 'p {background:url( "/wp-content/themes/test/http-is-awesome.png" );}',
+                        ),
+                        'URLs with path beginning with https'          => array(
+                                'css'      => 'p {background:url( "https-is-more-awesome.png" );}',
+                                'expected' => 'p {background:url( "/wp-content/themes/test/https-is-more-awesome.png" );}',
                         ),
                 );