Changeset 55745 for trunk/tests/phpunit/tests/comment/getPageOfComment.php

Timestamp:

05/11/2023 10:05:51 AM (16 months ago)

Author:

spacedmonkey

Message:

Tests: Use the function get_num_queries across all unit tests.

Replace use of $wpdb->num_queries with a function call to get_num_queries. This improves readability and consistency between tests.

Props SergeyBiryukov, peterwilsoncc, spacedmonkey.
See #57841.

File:

• trunk/tests/phpunit/tests/comment/getPageOfComment.php (modified) (5 diffs)

trunk/tests/phpunit/tests/comment/getPageOfComment.php

@@ -101 +101 @@
      */
     public function test_subsequent_calls_should_hit_cache() {
-        global $wpdb;
-
         $p = self::factory()->post->create();
         $c = self::factory()->comment->create( array( 'comment_post_ID' => $p ) );
@@ -109 +107 @@
         $page_1 = get_page_of_comment( $c, array( 'per_page' => 3 ) );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
         $page_2      = get_page_of_comment( $c, array( 'per_page' => 3 ) );
 
         $this->assertSame( $page_1, $page_2 );
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
     }
 
@@ -120 +118 @@
      */
     public function test_cache_hits_should_be_sensitive_to_comment_type() {
-        global $wpdb;
-
         $p       = self::factory()->post->create();
         $comment = self::factory()->comment->create(
@@ -152 +148 @@
         $this->assertSame( 2, $page_trackbacks );
 
-        $num_queries   = $wpdb->num_queries;
+        $num_queries   = get_num_queries();
         $page_comments = get_page_of_comment(
             $comment,
@@ -162 +158 @@
         $this->assertSame( 1, $page_comments );
 
-        $this->assertNotEquals( $num_queries, $wpdb->num_queries );
+        $this->assertNotEquals( $num_queries, get_num_queries() );
     }