Changeset 55745 for trunk/tests/phpunit/tests/comment/wpUpdateCommentCountNow.php

Timestamp:

05/11/2023 10:05:51 AM (19 months ago)

Author:

spacedmonkey

Message:

Tests: Use the function get_num_queries across all unit tests.

Replace use of $wpdb->num_queries with a function call to get_num_queries. This improves readability and consistency between tests.

Props SergeyBiryukov, peterwilsoncc, spacedmonkey.
See #57841.

File:

• trunk/tests/phpunit/tests/comment/wpUpdateCommentCountNow.php (modified) (3 diffs)

trunk/tests/phpunit/tests/comment/wpUpdateCommentCountNow.php

@@ -15 +15 @@
 
     public function test_regular_post_updates_comment_count() {
-        global $wpdb;
-
         $post_id = self::factory()->post->create();
 
@@ -22 +20 @@
         $this->assertSame( '1', get_comments_number( $post_id ) );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
         $this->assertTrue( wp_update_comment_count_now( $post_id ) );
-        $this->assertSame( $num_queries + 2, $wpdb->num_queries );
+        $this->assertSame( $num_queries + 2, get_num_queries() );
 
         $this->assertSame( '1', get_comments_number( $post_id ) );
@@ -39 +37 @@
         $this->assertSame( '100', get_comments_number( $post_id ) );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
         $this->assertTrue( wp_update_comment_count_now( $post_id ) );
         // Only one query is made instead of two.
-        $this->assertSame( $num_queries + 1, $wpdb->num_queries );
+        $this->assertSame( $num_queries + 1, get_num_queries() );
 
         $this->assertSame( '100', get_comments_number( $post_id ) );