Changeset 55745 for trunk/tests/phpunit/tests/multisite/wpNetworkQuery.php

Timestamp:

05/11/2023 10:05:51 AM (3 years ago)

Author:

spacedmonkey

Message:

Tests: Use the function get_num_queries across all unit tests.

Replace use of $wpdb->num_queries with a function call to get_num_queries. This improves readability and consistency between tests.

Props SergeyBiryukov, peterwilsoncc, spacedmonkey.
See #57841.

File:

• trunk/tests/phpunit/tests/multisite/wpNetworkQuery.php (modified) (11 diffs)

trunk/tests/phpunit/tests/multisite/wpNetworkQuery.php

@@ -429 +429 @@
          */
         public function test_wp_network_query_cache_with_different_fields_no_count() {
-            global $wpdb;
-
             $q                 = new WP_Network_Query();
             $query_1           = $q->query(
@@ -439 +437 @@
                 )
             );
-            $number_of_queries = $wpdb->num_queries;
+            $number_of_queries = get_num_queries();
 
             $query_2 = $q->query(
@@ -449 +447 @@
             );
 
-            $this->assertSame( $number_of_queries, $wpdb->num_queries );
+            $this->assertSame( $number_of_queries, get_num_queries() );
         }
 
@@ -456 +454 @@
          */
         public function test_wp_network_query_cache_with_different_fields_active_count() {
-            global $wpdb;
-
             $q = new WP_Network_Query();
 
@@ -468 +464 @@
                 )
             );
-            $number_of_queries = $wpdb->num_queries;
+            $number_of_queries = get_num_queries();
 
             $query_2 = $q->query(
@@ -478 +474 @@
                 )
             );
-            $this->assertSame( $number_of_queries, $wpdb->num_queries );
+            $this->assertSame( $number_of_queries, get_num_queries() );
         }
 
@@ -485 +481 @@
          */
         public function test_wp_network_query_cache_with_same_fields_different_count() {
-            global $wpdb;
-
             $q = new WP_Network_Query();
 
@@ -497 +491 @@
             );
 
-            $number_of_queries = $wpdb->num_queries;
+            $number_of_queries = get_num_queries();
 
             $query_2 = $q->query(
@@ -507 +501 @@
                 )
             );
-            $this->assertSame( $number_of_queries + 1, $wpdb->num_queries );
+            $this->assertSame( $number_of_queries + 1, get_num_queries() );
         }
 
@@ -569 +563 @@
          */
         public function test_networks_pre_query_filter_should_bypass_database_query() {
-            global $wpdb;
-
             add_filter( 'networks_pre_query', array( __CLASS__, 'filter_networks_pre_query' ), 10, 2 );
 
-            $num_queries = $wpdb->num_queries;
+            $num_queries = get_num_queries();
 
             $q       = new WP_Network_Query();
@@ -581 +573 @@
 
             // Make sure no queries were executed.
-            $this->assertSame( $num_queries, $wpdb->num_queries );
+            $this->assertSame( $num_queries, get_num_queries() );
 
             // We manually inserted a non-existing site and overrode the results with it.