Changeset 55745 for trunk/tests/phpunit/tests/term/getTerm.php

Timestamp:

05/11/2023 10:05:51 AM (2 years ago)

Author:

spacedmonkey

Message:

Tests: Use the function get_num_queries across all unit tests.

Replace use of $wpdb->num_queries with a function call to get_num_queries. This improves readability and consistency between tests.

Props SergeyBiryukov, peterwilsoncc, spacedmonkey.
See #57841.

File:

• trunk/tests/phpunit/tests/term/getTerm.php (modified) (5 diffs)

trunk/tests/phpunit/tests/term/getTerm.php

@@ -61 +61 @@
 
     public function test_passing_term_object_should_skip_database_query_when_filter_property_is_empty() {
-        global $wpdb;
-
         $term = self::factory()->term->create_and_get( array( 'taxonomy' => 'wptests_tax' ) );
         clean_term_cache( $term->term_id, 'wptests_tax' );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
 
         unset( $term->filter );
         $term_a = get_term( $term, 'wptests_tax' );
 
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
     }
 
@@ -83 +81 @@
 
     public function test_cache_should_be_populated_by_successful_fetch() {
-        global $wpdb;
-
         $t = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax' ) );
         clean_term_cache( $t, 'wptests_tax' );
@@ -90 +86 @@
         // Prime cache.
         $term_a      = get_term( $t, 'wptests_tax' );
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
 
         // Second call shouldn't require a database query.
         $term_b = get_term( $t, 'wptests_tax' );
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
         $this->assertEquals( $term_a, $term_b );
     }
@@ -197 +193 @@
      */
     public function test_shared_term_in_cache_should_be_ignored_when_specifying_a_different_taxonomy() {
-        global $wpdb;
-
         $terms = $this->generate_shared_terms();
 
         // Prime cache for 'wptests_tax'.
         get_term( $terms[0]['term_id'], 'wptests_tax' );
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
 
         // Database should be hit again.
@@ -209 +203 @@
         $num_queries++;
 
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
         $this->assertInstanceOf( 'WP_Term', $found );
         $this->assertSame( 'wptests_tax_2', $found->taxonomy );