Changeset 55745 for trunk/tests/phpunit/tests/term/getTermBy.php

Timestamp:

05/11/2023 10:05:51 AM (3 years ago)

Author:

spacedmonkey

Message:

Tests: Use the function get_num_queries across all unit tests.

Replace use of $wpdb->num_queries with a function call to get_num_queries. This improves readability and consistency between tests.

Props SergeyBiryukov, peterwilsoncc, spacedmonkey.
See #57841.

File:

• trunk/tests/phpunit/tests/term/getTermBy.php (modified) (3 diffs)

trunk/tests/phpunit/tests/term/getTermBy.php

@@ -112 +112 @@
      */
     public function test_should_prime_term_cache() {
-        global $wpdb;
-
         register_taxonomy( 'wptests_tax', 'post' );
         $t = self::factory()->term->create(
@@ -124 +122 @@
         clean_term_cache( $t, 'wptests_tax' );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
         $found       = get_term_by( 'slug', 'foo', 'wptests_tax' );
         $num_queries = $num_queries + 2;
@@ -130 +128 @@
         $this->assertInstanceOf( 'WP_Term', $found );
         $this->assertSame( $t, $found->term_id );
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
 
         // Calls to `get_term()` should now hit cache.
         $found2 = get_term( $t );
         $this->assertSame( $t, $found->term_id );
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
     }