Changeset 55745 for trunk/tests/phpunit/tests/term/isObjectInTerm.php

Timestamp:

05/11/2023 10:05:51 AM (3 years ago)

Author:

spacedmonkey

Message:

Tests: Use the function get_num_queries across all unit tests.

Replace use of $wpdb->num_queries with a function call to get_num_queries. This improves readability and consistency between tests.

Props SergeyBiryukov, peterwilsoncc, spacedmonkey.
See #57841.

File:

• trunk/tests/phpunit/tests/term/isObjectInTerm.php (modified) (4 diffs)

trunk/tests/phpunit/tests/term/isObjectInTerm.php

@@ -136 +136 @@
      */
     public function test_should_populate_and_hit_relationships_cache() {
-        global $wpdb;
-
         register_taxonomy( 'wptests_tax', 'post' );
         $terms = self::factory()->term->create_many( 2, array( 'taxonomy' => 'wptests_tax' ) );
@@ -144 +142 @@
         wp_set_object_terms( $o, $terms[0], 'wptests_tax' );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
         $this->assertTrue( is_object_in_term( $o, 'wptests_tax', $terms[0] ) );
         $num_queries = $num_queries + 2;
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
 
         $this->assertFalse( is_object_in_term( $o, 'wptests_tax', $terms[1] ) );
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
     }
 
@@ -157 +155 @@
      */
     public function test_should_not_be_fooled_by_a_stale_relationship_cache() {
-        global $wpdb;
-
         register_taxonomy( 'wptests_tax', 'post' );
         $terms = self::factory()->term->create_many( 2, array( 'taxonomy' => 'wptests_tax' ) );
@@ -165 +161 @@
         wp_set_object_terms( $o, $terms[0], 'wptests_tax' );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
         $this->assertTrue( is_object_in_term( $o, 'wptests_tax', $terms[0] ) );
         $num_queries = $num_queries + 2;
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
 
         wp_set_object_terms( $o, $terms[1], 'wptests_tax' );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
         $this->assertTrue( is_object_in_term( $o, 'wptests_tax', $terms[1] ) );
         $num_queries = $num_queries + 2;
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
     }