Changeset 55745 for trunk/tests/phpunit/tests/term/meta.php

Timestamp:

05/11/2023 10:05:51 AM (3 years ago)

Author:

spacedmonkey

Message:

Tests: Use the function get_num_queries across all unit tests.

Replace use of $wpdb->num_queries with a function call to get_num_queries. This improves readability and consistency between tests.

Props SergeyBiryukov, peterwilsoncc, spacedmonkey.
See #57841.

File:

• trunk/tests/phpunit/tests/term/meta.php (modified) (4 diffs)

trunk/tests/phpunit/tests/term/meta.php

@@ -115 +115 @@
 
     public function test_term_meta_should_be_lazy_loaded_for_all_terms_in_wp_query_loop() {
-        global $wpdb;
-
         $p = self::factory()->post->create( array( 'post_status' => 'publish' ) );
 
@@ -140 +138 @@
 
                 // First request will hit the database.
-                $num_queries = $wpdb->num_queries;
+                $num_queries = get_num_queries();
                 $this->assertSame( 'bar', get_term_meta( $terms[0], 'foo', true ) );
                 $num_queries++;
-                $this->assertSame( $num_queries, $wpdb->num_queries );
+                $this->assertSame( $num_queries, get_num_queries() );
 
                 // Second and third requests should be in cache.
                 $this->assertSame( 'bar', get_term_meta( $terms[1], 'foo', true ) );
                 $this->assertSame( 'bar', get_term_meta( $terms[2], 'foo', true ) );
-                $this->assertSame( $num_queries, $wpdb->num_queries );
+                $this->assertSame( $num_queries, get_num_queries() );
 
                 // Querying a term not primed should result in a hit.
                 $num_queries++;
                 $this->assertSame( 'bar', get_term_meta( $orphan_term, 'foo', true ) );
-                $this->assertSame( $num_queries, $wpdb->num_queries );
+                $this->assertSame( $num_queries, get_num_queries() );
             }
         }
@@ -187 +185 @@
      */
     public function test_lazy_load_term_meta_false() {
-        global $wpdb;
-
         $p = self::factory()->post->create( array( 'post_status' => 'publish' ) );
 
@@ -211 +207 @@
 
                 // Requests will hit the database.
-                $num_queries = $wpdb->num_queries;
+                $num_queries = get_num_queries();
                 $this->assertSame( 'bar', get_term_meta( $terms[0], 'foo', true ) );
                 $num_queries++;
-                $this->assertSame( $num_queries, $wpdb->num_queries );
+                $this->assertSame( $num_queries, get_num_queries() );
 
                 $this->assertSame( 'bar', get_term_meta( $terms[1], 'foo', true ) );
                 $num_queries++;
-                $this->assertSame( $num_queries, $wpdb->num_queries );
+                $this->assertSame( $num_queries, get_num_queries() );
             }
         }