Changeset 55745 for trunk/tests/phpunit/tests/term/query.php

Timestamp:

05/11/2023 10:05:51 AM (2 years ago)

Author:

spacedmonkey

Message:

Tests: Use the function get_num_queries across all unit tests.

Replace use of $wpdb->num_queries with a function call to get_num_queries. This improves readability and consistency between tests.

Props SergeyBiryukov, peterwilsoncc, spacedmonkey.
See #57841.

File:

• trunk/tests/phpunit/tests/term/query.php (modified) (5 diffs)

trunk/tests/phpunit/tests/term/query.php

@@ -457 +457 @@
      */
     public function test_count_query_should_be_cached() {
-        global $wpdb;
-
         register_taxonomy( 'wptests_tax_1', 'post' );
 
@@ -473 +471 @@
         $this->assertEquals( 2, $count );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
 
         $query = new WP_Term_Query(
@@ -484 +482 @@
         $count = $query->get_terms();
         $this->assertEquals( 2, $count );
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
     }
 
@@ -804 +802 @@
      */
     public function test_terms_pre_query_filter_should_bypass_database_query() {
-        global $wpdb;
-
         add_filter( 'terms_pre_query', array( __CLASS__, 'filter_terms_pre_query' ), 10, 2 );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
 
         $q       = new WP_Term_Query();
@@ -820 +816 @@
 
         // Make sure no queries were executed.
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
 
         // We manually inserted a non-existing term and overrode the results with it.