Changeset 55745 for trunk/tests/phpunit/tests/term/wpGetObjectTerms.php

Timestamp:

05/11/2023 10:05:51 AM (2 years ago)

Author:

spacedmonkey

Message:

Tests: Use the function get_num_queries across all unit tests.

Replace use of $wpdb->num_queries with a function call to get_num_queries. This improves readability and consistency between tests.

Props SergeyBiryukov, peterwilsoncc, spacedmonkey.
See #57841.

File:

• trunk/tests/phpunit/tests/term/wpGetObjectTerms.php (modified) (16 diffs)

trunk/tests/phpunit/tests/term/wpGetObjectTerms.php

@@ -617 +617 @@
      */
     public function test_termmeta_cache_should_be_lazy_loaded_by_default() {
-        global $wpdb;
-
         register_taxonomy( 'wptests_tax', 'post' );
         $terms = self::factory()->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
@@ -630 +628 @@
         $found = wp_get_object_terms( $p, 'wptests_tax' );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
 
         foreach ( $terms as $t ) {
@@ -636 +634 @@
         }
 
-        $this->assertSame( $num_queries + 1, $wpdb->num_queries );
+        $this->assertSame( $num_queries + 1, get_num_queries() );
     }
 
@@ -643 +641 @@
      */
     public function test_termmeta_cache_should_not_be_primed_when_update_term_meta_cache_is_false() {
-        global $wpdb;
-
         register_taxonomy( 'wptests_tax', 'post' );
         $terms = self::factory()->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
@@ -662 +658 @@
         );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
 
         foreach ( $terms as $t ) {
@@ -668 +664 @@
         }
 
-        $this->assertSame( $num_queries + 3, $wpdb->num_queries );
+        $this->assertSame( $num_queries + 3, get_num_queries() );
     }
 
@@ -675 +671 @@
      */
     public function test_termmeta_cache_should_be_primed_when_fields_is_all_with_object_id() {
-        global $wpdb;
-
         register_taxonomy( 'wptests_tax', 'post' );
         $terms = self::factory()->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
@@ -695 +689 @@
         );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
 
         foreach ( $terms as $t ) {
@@ -701 +695 @@
         }
 
-        $this->assertSame( $num_queries + 1, $wpdb->num_queries );
+        $this->assertSame( $num_queries + 1, get_num_queries() );
     }
 
@@ -708 +702 @@
      */
     public function test_termmeta_cache_should_be_primed_when_fields_is_ids() {
-        global $wpdb;
-
         register_taxonomy( 'wptests_tax', 'post' );
         $terms = self::factory()->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
@@ -728 +720 @@
         );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
 
         foreach ( $terms as $t ) {
@@ -734 +726 @@
         }
 
-        $this->assertSame( $num_queries + 1, $wpdb->num_queries );
+        $this->assertSame( $num_queries + 1, get_num_queries() );
     }
 
@@ -817 +809 @@
      */
     public function test_should_prime_cache_for_found_terms() {
-        global $wpdb;
-
         register_taxonomy( 'wptests_tax', 'post' );
         $p = self::factory()->post->create();
@@ -832 +822 @@
         );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
         $term        = get_term( $t );
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
     }
 
@@ -866 +856 @@
      */
     public function test_term_cache_should_be_primed_for_all_taxonomies() {
-        global $wpdb;
-
         register_taxonomy( 'wptests_tax1', 'post' );
         register_taxonomy( 'wptests_tax2', 'post' );
@@ -889 +877 @@
         $this->assertSameSets( array( $t1, $t2 ), wp_list_pluck( $found, 'term_id' ) );
 
-        $num_queries = $wpdb->num_queries;
+        $num_queries = get_num_queries();
         $term1       = get_term( $t1 );
         $term2       = get_term( $t2 );
-        $this->assertSame( $num_queries, $wpdb->num_queries );
+        $this->assertSame( $num_queries, get_num_queries() );
     }