Changeset 55747 for trunk/tests/phpunit/tests/multisite/siteMeta.php

Timestamp:

05/11/2023 11:13:10 AM (2 years ago)

Author:

spacedmonkey

Message:

Networks and Sites: Lazy load site meta.

In [36566] a framework to lazily load metadata was introduced. This supported term and comment meta by default. In this commit, extends support for site ( blog ) meta. Site meta is not heavily used by core and is used by developers to extend multisite. In this change, _prime_site_caches and WP_Site_Query now call the new function wp_lazyload_site_meta. The function wp_lazyload_site_meta accepts an array of ids and adds them to the queue of metadata to be lazily loaded. The function get_blogs_of_user was updated to now lazily load site meta.

Follow on from [55671].

Props spacedmonkey, johnjamesjacoby, peterwilsoncc, mukesh27.
Fixes #58185.

File:

• trunk/tests/phpunit/tests/multisite/siteMeta.php (modified) (2 diffs)

trunk/tests/phpunit/tests/multisite/siteMeta.php

@@ -249 +249 @@
             $num_queries = get_num_queries();
             get_site_meta( self::$site_id, 'foo', true );
-            $this->assertSame( $num_queries, get_num_queries() );
+            $this->assertSame( 1, get_num_queries() - $num_queries );
+        }
+
+        /**
+         * @ticket 58185
+         */
+        public function test_lazy_load_site_meta() {
+            if ( ! is_site_meta_supported() ) {
+                $this->markTestSkipped( 'Test only runs with the blogmeta database table installed.' );
+            }
+
+            $filter = new MockAction();
+            add_filter( 'update_blog_metadata_cache', array( $filter, 'filter' ), 10, 2 );
+
+            $q = new WP_Site_Query(
+                array(
+                    'ID' => self::$site_id,
+                )
+            );
+
+            $this->assertSameSets( array( (string) self::$site_id ), wp_list_pluck( $q->sites, 'blog_id' ), 'Site query should return the first test site' );
+
+            $q = new WP_Site_Query(
+                array(
+                    'ID' => self::$site_id2,
+                )
+            );
+
+            $this->assertSameSets( array( (string) self::$site_id2 ), wp_list_pluck( $q->sites, 'blog_id' ), 'Site query should return the second test site' );
+
+            get_site_meta( self::$site_id2 );
+
+            $args     = $filter->get_args();
+            $first    = reset( $args );
+            $site_ids = end( $first );
+            $this->assertSameSets( $site_ids, array( self::$site_id, self::$site_id2 ), 'This should have two site\'s meta' );
+        }
+
+        /**
+         * @ticket 58185
+         */
+        public function test_lazy_load_site_meta_fields_id() {
+            if ( ! is_site_meta_supported() ) {
+                $this->markTestSkipped( 'Test only runs with the blogmeta database table installed.' );
+            }
+
+            $filter = new MockAction();
+            add_filter( 'update_blog_metadata_cache', array( $filter, 'filter' ), 10, 2 );
+
+            $q = new WP_Site_Query(
+                array(
+                    'ID'     => self::$site_id,
+                    'fields' => 'ids',
+                )
+            );
+
+            $this->assertSameSets( array( self::$site_id ), $q->sites, 'Site query should return the first test site' );
+
+            $q = new WP_Site_Query(
+                array(
+                    'ID'     => self::$site_id2,
+                    'fields' => 'ids',
+                )
+            );
+
+            $this->assertSameSets( array( self::$site_id2 ), $q->sites, 'Site query should return the second test site' );
+
+            get_site_meta( self::$site_id2 );
+
+            $args     = $filter->get_args();
+            $first    = reset( $args );
+            $site_ids = end( $first );
+            $this->assertSameSets( $site_ids, array( self::$site_id, self::$site_id2 ), 'This should have two sites meta' );
         }
 
@@ -268 +340 @@
             $num_queries = get_num_queries();
             get_site_meta( self::$site_id, 'foo', true );
-            $this->assertSame( $num_queries + 1, get_num_queries() );
+            $this->assertSame( 1, get_num_queries() - $num_queries );
         }