Changeset 55748

Timestamp:

05/11/2023 11:42:00 AM (16 months ago)

Author:

SergeyBiryukov

Message:

Plugins: Remove is_object() check in WP_Hook:build_preinitialized_hooks().

This is a minor performance enhancement:

• If an object is passed, the call to is_object() will be redundant.
• If a non-object is passed, the instanceof operator (a variant of is_a()) will first ​check if it is an object before doing any further processing.

Therefore, no additional processing cycles should be wasted in both cases.

Follow-up to [38571].

Props bor0, johnbillion, davidbaumwald.
Fixes #58290.

File:

• trunk/src/wp-includes/class-wp-hook.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-hook.php

@@ -291 +291 @@
 
         $this->iterations[ $nesting_level ] = array_keys( $this->callbacks );
-        $num_args                           = count( $args );
+
+        $num_args = count( $args );
 
         do {
             $this->current_priority[ $nesting_level ] = current( $this->iterations[ $nesting_level ] );
-            $priority                                 = $this->current_priority[ $nesting_level ];
+
+            $priority = $this->current_priority[ $nesting_level ];
 
             foreach ( $this->callbacks[ $priority ] as $the_ ) {
@@ -411 +413 @@
 
         foreach ( $filters as $hook_name => $callback_groups ) {
-            if ( is_object( $callback_groups ) && $callback_groups instanceof WP_Hook ) {
+            if ( $callback_groups instanceof WP_Hook ) {
                 $normalized[ $hook_name ] = $callback_groups;
                 continue;