Changeset 55749 for trunk/src/wp-includes/comment.php

Timestamp:

05/11/2023 12:25:51 PM (17 months ago)

Author:

spacedmonkey

Message:

Comments: Always lazily load comment meta.

In [34270] introduced lazy loading of comment meta. However, this was only in the context of WP_Query. Other parts of the codebase, like WP_Comment_Query did not lazily load comment meta. In this change, calls to update_meta_cache are now replaced with wp_lazyload_comment_meta, that instead of priming comment meta caches, just adds them to the queue to be primed it ever called. This results in far less database queries, as there a number of places where comment meta is being primed unnecessarily and never used. Adding everything to the comment meta queue, also means that if comment meta is used, that is all loaded in a single database / cache call.

Follow on from [55671], [55747].

Props spacedmonkey, peterwilsoncc, flixos90, mukesh27.
Fixes #57801.

File:

• trunk/src/wp-includes/comment.php (modified) (5 diffs)

trunk/src/wp-includes/comment.php

@@ -486 +486 @@
 
 /**
+ * Queue comment meta for lazy-loading.
+ *
+ * @since 6.3.0
+ *
+ * @param array $comment_ids List of comment IDs.
+ */
+function wp_lazyload_comment_meta( array $comment_ids ) {
+    if ( empty( $comment_ids ) ) {
+        return;
+    }
+    $lazyloader = wp_metadata_lazyloader();
+    $lazyloader->queue_objects( 'comment', $comment_ids );
+}
+
+/**
  * Updates comment meta field based on comment ID.
  *
@@ -515 +530 @@
  *
  * @since 4.5.0
+ * @since 6.3.0 Use wp_lazyload_comment_meta() for lazy-loading of comment meta.
+ *
+ * @see wp_lazyload_comment_meta()
  *
  * @param WP_Comment[] $comments Array of comment objects.
@@ -529 +547 @@
     }
 
-    if ( $comment_ids ) {
-        $lazyloader = wp_metadata_lazyloader();
-        $lazyloader->queue_objects( 'comment', $comment_ids );
-    }
+    wp_lazyload_comment_meta( $comment_ids );
 }
 
@@ -3332 +3347 @@
  * @since 4.4.0
  * @since 6.1.0 This function is no longer marked as "private".
+ * @since 6.3.0 Use wp_lazyload_comment_meta() for lazy-loading of comment meta.
  *
  * @see update_comment_cache()
@@ -3346 +3362 @@
         $fresh_comments = $wpdb->get_results( sprintf( "SELECT $wpdb->comments.* FROM $wpdb->comments WHERE comment_ID IN (%s)", implode( ',', array_map( 'intval', $non_cached_ids ) ) ) );
 
-        update_comment_cache( $fresh_comments, $update_meta_cache );
+        update_comment_cache( $fresh_comments, false );
+    }
+
+    if ( $update_meta_cache ) {
+        wp_lazyload_comment_meta( $comment_ids );
     }
 }