Changeset 55757

Timestamp:

05/15/2023 10:26:54 AM (20 months ago)

Author:

SergeyBiryukov

Message:

General: Remove a few is_object() checks followed by instanceof operator.

This is a minor performance enhancement:

• If an object is passed, the call to is_object() will be redundant.
• If a non-object is passed, the instanceof operator (a variant of is_a()) will first ​check if it is an object before doing any further processing.

Therefore, no additional processing cycles should be wasted in both cases.

Follow-up to [6779], [48798], [48905], [49194], [55748].

Props Presskopp, costdev.
Fixes #58309.

Location:

trunk/src

Files:

• wp-admin/includes/class-pclzip.php (modified) (2 diffs)
• wp-includes/media.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-pclzip.php

@@ -1171 +1171 @@
     $this->privErrorReset();
 
-    // ----- Look if the $p_archive is a PclZip object
-    if (is_object($p_archive) && $p_archive instanceof pclzip)
+    // ----- Look if the $p_archive is an instantiated PclZip object
+    if ($p_archive instanceof pclzip)
     {
 
@@ -1235 +1235 @@
     }
 
-    // ----- Look if the $p_archive_to_add is a PclZip object
-    if (is_object($p_archive_to_add) && $p_archive_to_add instanceof pclzip)
+    // ----- Look if the $p_archive_to_add is an instantiated PclZip object
+    if ($p_archive_to_add instanceof pclzip)
     {
 

trunk/src/wp-includes/media.php

@@ -3749 +3749 @@
  *
  * In PHP 8.0, the GD extension uses GdImage objects for its data structures.
- * This function checks if the passed value is either a resource of type `gd`
- * or a GdImage object instance. Any other type will return false.
+ * This function checks if the passed value is either a GdImage object instance
+ * or a resource of type `gd`. Any other type will return false.
  *
  * @since 5.6.0
@@ -3759 +3759 @@
  */
 function is_gd_image( $image ) {
-    if ( is_resource( $image ) && 'gd' === get_resource_type( $image )
-        || is_object( $image ) && $image instanceof GdImage
+    if ( $image instanceof GdImage
+        || is_resource( $image ) && 'gd' === get_resource_type( $image )
     ) {
         return true;