Changeset 55759

Timestamp:

05/16/2023 12:29:34 PM (19 months ago)

Author:

spacedmonkey

Message:

Taxonomy: Do not prime term meta in wp_get_object_terms.

Passing update_term_meta_cache argument value false by default resulting in get_terms to not prime the term meta cache in wp_get_object_terms. Priming of term meta is not needed in this context.

Props spacedmonkey, rutviksavsani.
Fixes #57701.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (2 diffs)
• tests/phpunit/tests/term/getTheTerms.php (modified) (2 diffs)
• tests/phpunit/tests/term/wpGetObjectTerms.php (modified) (2 diffs)

trunk/src/wp-includes/taxonomy.php

@@ -2193 +2193 @@
  *              'all_with_object_id', an array of `WP_Term` objects will be returned.
  * @since 4.7.0 Refactored to use WP_Term_Query, and to support any WP_Term_Query arguments.
+ * @since 6.3.0 Passing `update_term_meta_cache` argument value false by default resulting in get_terms() to not
+ *              prime the term meta cache.
  *
  * @param int|int[]       $object_ids The ID(s) of the object(s) to retrieve.
@@ -2221 +2223 @@
     $object_ids = array_map( 'intval', $object_ids );
 
-    $args = wp_parse_args( $args );
+    $defaults = array(
+        'update_term_meta_cache' => false,
+    );
+
+    $args = wp_parse_args( $args, $defaults );
 
     /**

trunk/tests/phpunit/tests/term/getTheTerms.php

@@ -196 +196 @@
     /**
      * @ticket 36814
-     */
-    public function test_uncached_terms_should_be_primed_with_a_single_query() {
+     * @ticket 57701
+     */
+    public function test_uncached_terms_should_not_be_primed_with_a_single_query_by_default() {
         register_taxonomy( 'wptests_tax', 'post' );
 
@@ -214 +215 @@
         $this->assertSameSets( $terms, wp_list_pluck( $found, 'term_id' ) );
 
-        $num_queries++;
-        $this->assertSame( $num_queries, get_num_queries() );
-
+        // Two extra queries are expected as the cache is not primed and hence terms need to be queried.
+        $this->assertSame( 1, get_num_queries() - $num_queries );
     }
 

trunk/tests/phpunit/tests/term/wpGetObjectTerms.php

@@ -615 +615 @@
     /**
      * @ticket 10142
-     */
-    public function test_termmeta_cache_should_be_lazy_loaded_by_default() {
+     * @ticket 57701
+     */
+    public function test_termmeta_cache_should_not_be_lazy_loaded_by_default() {
         register_taxonomy( 'wptests_tax', 'post' );
         $terms = self::factory()->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
@@ -634 +635 @@
         }
 
-        $this->assertSame( $num_queries + 1, get_num_queries() );
+        // Here we had extra queries as the term meta cache was not primed by default.
+        $this->assertSame( 3, get_num_queries() - $num_queries );
     }