Changeset 55759 for trunk/tests/phpunit/tests/term/getTheTerms.php

Timestamp:

05/16/2023 12:29:34 PM (3 years ago)

Author:

spacedmonkey

Message:

Taxonomy: Do not prime term meta in wp_get_object_terms.

Passing update_term_meta_cache argument value false by default resulting in get_terms to not prime the term meta cache in wp_get_object_terms. Priming of term meta is not needed in this context.

Props spacedmonkey, rutviksavsani.
Fixes #57701.

File:

• trunk/tests/phpunit/tests/term/getTheTerms.php (modified) (2 diffs)

trunk/tests/phpunit/tests/term/getTheTerms.php

@@ -196 +196 @@
     /**
      * @ticket 36814
-     */
-    public function test_uncached_terms_should_be_primed_with_a_single_query() {
+     * @ticket 57701
+     */
+    public function test_uncached_terms_should_not_be_primed_with_a_single_query_by_default() {
         register_taxonomy( 'wptests_tax', 'post' );
 
@@ -214 +215 @@
         $this->assertSameSets( $terms, wp_list_pluck( $found, 'term_id' ) );
 
-        $num_queries++;
-        $this->assertSame( $num_queries, get_num_queries() );
-
+        // Two extra queries are expected as the cache is not primed and hence terms need to be queried.
+        $this->assertSame( 1, get_num_queries() - $num_queries );
     }