Changeset 55759 for trunk/tests/phpunit/tests/term/wpGetObjectTerms.php

Timestamp:

05/16/2023 12:29:34 PM (3 years ago)

Author:

spacedmonkey

Message:

Taxonomy: Do not prime term meta in wp_get_object_terms.

Passing update_term_meta_cache argument value false by default resulting in get_terms to not prime the term meta cache in wp_get_object_terms. Priming of term meta is not needed in this context.

Props spacedmonkey, rutviksavsani.
Fixes #57701.

File:

• trunk/tests/phpunit/tests/term/wpGetObjectTerms.php (modified) (2 diffs)

trunk/tests/phpunit/tests/term/wpGetObjectTerms.php

@@ -615 +615 @@
         /**
          * @ticket 10142
-         */
-        public function test_termmeta_cache_should_be_lazy_loaded_by_default() {
+         * @ticket 57701
+         */
+        public function test_termmeta_cache_should_not_be_lazy_loaded_by_default() {
                 register_taxonomy( 'wptests_tax', 'post' );
                 $terms = self::factory()->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
@@ -634 +635 @@
                 }
 
-                $this->assertSame( $num_queries + 1, get_num_queries() );
+                // Here we had extra queries as the term meta cache was not primed by default.
+                $this->assertSame( 3, get_num_queries() - $num_queries );
         }