Changeset 55816 for trunk/src/wp-includes/media.php

Timestamp:

05/16/2023 06:50:11 PM (19 months ago)

Author:

flixos90

Message:

Media: Increase default for wp_omit_loading_attr_threshold to 3.

The previous default threshold for how many content images to skip lazy-loading on (which was just 1) has proven to be too strict: HTTP Archive data shows that >70% of sites have up to 3 equal-sized images in the initial viewport, each of which could be the LCP image and therefore should not be lazy-loaded. Lazy-loading too many images has adverse effects on load time performance, while increasing the default threshold will not negatively affect load time performance even for sites where a threshold of 1 would be the perfect choice.

The change of default value in this changeset will improve performance for more WordPress sites out of the box. The wp_omit_loading_attr_threshold filter can still be used to customize and fine tune the value where needed.

Props thekt12, spacedmonkey, westonruter, flixos90.
Fixes #58213.

File:

• trunk/src/wp-includes/media.php (modified) (3 diffs)

trunk/src/wp-includes/media.php

@@ -5436 +5436 @@
  * Under the hood, the function uses {@see wp_increase_content_media_count()} every time it is called for an element
  * within the main content. If the element is the very first content element, the `loading` attribute will be omitted.
- * This default threshold of 1 content element to omit the `loading` attribute for can be customized using the
+ * This default threshold of 3 content elements to omit the `loading` attribute for can be customized using the
  * {@see 'wp_omit_loading_attr_threshold'} filter.
  *
@@ -5486 +5486 @@
  * Gets the threshold for how many of the first content media elements to not lazy-load.
  *
- * This function runs the {@see 'wp_omit_loading_attr_threshold'} filter, which uses a default threshold value of 1.
+ * This function runs the {@see 'wp_omit_loading_attr_threshold'} filter, which uses a default threshold value of 3.
  * The filter is only run once per page load, unless the `$force` parameter is used.
  *
@@ -5507 +5507 @@
          *
          * @since 5.9.0
+         * @since 6.3.0 The default threshold was changed from 1 to 3.
          *
-         * @param int $omit_threshold The number of media elements where the `loading` attribute will not be added. Default 1.
+         * @param int $omit_threshold The number of media elements where the `loading` attribute will not be added. Default 3.
          */
-        $omit_threshold = apply_filters( 'wp_omit_loading_attr_threshold', 1 );
+        $omit_threshold = apply_filters( 'wp_omit_loading_attr_threshold', 3 );
     }