Changeset 55851

Timestamp:

05/23/2023 09:58:56 PM (3 years ago)

Author:

SergeyBiryukov

Message:

General: Improve performance of the _wp_array_get() function.

When using a block theme, _wp_array_get() is the most called function on the front end of a site.

This commit makes a few minor performance optimizations, which add up to a noticeable improvement.

Follow-up to [49135], [49143], [49580].

Props aristath, jrf, afercia, costdev, swissspidy, flixos90, spacedmonkey, mukesh27, samiamnot, SergeyBiryukov.
Fixes #58376.

File:

• trunk/src/wp-includes/functions.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -4948 +4948 @@
 
         foreach ( $path as $path_element ) {
-                if (
-                        ! is_array( $input_array ) ||
-                        ( ! is_string( $path_element ) && ! is_integer( $path_element ) && ! is_null( $path_element ) ) ||
-                        ! array_key_exists( $path_element, $input_array )
+                if ( ! is_array( $input_array ) ) {
+                        return $default_value;
+                }
+
+                if ( is_string( $path_element )
+                        || is_integer( $path_element )
+                        || null === $path_element
                 ) {
-                        return $default_value;
-                }
-                $input_array = $input_array[ $path_element ];
+                        /*
+                         * Check if the path element exists in the input array.
+                         * We check with `isset()` first, as it is a lot faster
+                         * than `array_key_exists()`.
+                         */
+                        if ( isset( $input_array[ $path_element ] ) ) {
+                                $input_array = $input_array[ $path_element ];
+                                continue;
+                        }
+
+                        /*
+                         * If `isset()` returns false, we check with `array_key_exists()`,
+                         * which also checks for `null` values.
+                         */
+                        if ( array_key_exists( $path_element, $input_array ) ) {
+                                $input_array = $input_array[ $path_element ];
+                                continue;
+                        }
+                }
+
+                return $default_value;
         }