Changeset 55859 for trunk/tests/phpunit/tests/ajax/wpAjaxImageEditor.php

Timestamp:

05/25/2023 03:15:45 PM (20 months ago)

Author:

antpb

Message:

Media: Prevent scaling up of images in the Image Editor.

Previously, when scaling an image larger than the source size in the image edit states the image would silently fail the scaling action. This patch provides an error when someone attempts to scale an image larger than the source size while also disabling the button to initiate the action.

Props brookedot, joedolson, markoheijnen, mikeschroder, desrosj, Mista-Flo, costdev.
Fixes #26381.

File:

• trunk/tests/phpunit/tests/ajax/wpAjaxImageEditor.php (modified) (1 diff)

trunk/tests/phpunit/tests/ajax/wpAjaxImageEditor.php

@@ -63 +63 @@
 
     /**
+     * @ticket 26381
+     * @requires function imagejpeg
+     *
+     * @covers ::wp_save_image
+     */
+    public function testCropImageIntoLargerOne() {
+        require_once ABSPATH . 'wp-admin/includes/image-edit.php';
+
+        $filename = DIR_TESTDATA . '/images/canola.jpg';
+        $contents = file_get_contents( $filename );
+
+        $upload = wp_upload_bits( wp_basename( $filename ), null, $contents );
+        $id     = $this->_make_attachment( $upload );
+
+        $_REQUEST['action']  = 'image-editor';
+        $_REQUEST['postid']  = $id;
+        $_REQUEST['do']      = 'scale';
+        $_REQUEST['fwidth']  = 700;
+        $_REQUEST['fheight'] = 500;
+
+        $ret = wp_save_image( $id );
+
+        $this->assertObjectHasAttribute( 'error', $ret );
+        $this->assertEquals( 'Images cannot be scaled to a size larger than the original.', $ret->error );
+    }
+
+    /**
      * @ticket 32171
      * @requires function imagejpeg