Changeset 55864

Timestamp:

05/28/2023 11:44:24 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Users: Make sure bulk actions are only executed with the Apply button, not Change.

The Change button is supposed to perform the “Change role to...” action only, but could unintentionally be used for other bulk actions if the role was not selected.

This commit removes an extra check and ensures the correct error message is displayed in that case:

Sorry, you are not allowed to give users that role.

Follow-up to [6990], [8691], [9028], [15576], [15642], [34636], [49944].

Props haritpanchal, costdev, ankit-k-gupta, SergeyBiryukov.
Fixes #57952.

File:

• trunk/src/wp-admin/includes/class-wp-users-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-users-list-table.php

@@ -354 +354 @@
      */
     public function current_action() {
-        if ( isset( $_REQUEST['changeit'] ) && ! empty( $_REQUEST['new_role'] ) ) {
+        if ( isset( $_REQUEST['changeit'] ) ) {
             return 'promote';
         }