Changeset 55873 for trunk/src/wp-admin/includes/menu.php

Timestamp:

05/31/2023 02:51:22 PM (16 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp-admin/includes/menu.php.

Includes minor code layout fixes for better readability.

Follow-up to [3536], [4093], [9578], [11092], [18034].

Props aristath, poena, afercia, SergeyBiryukov.
See #57839.

File:

• trunk/src/wp-admin/includes/menu.php (modified) (12 diffs)

trunk/src/wp-admin/includes/menu.php

@@ -45 +45 @@
 foreach ( $menu as $menu_page ) {
     $pos = strpos( $menu_page[2], '?' );
+
     if ( false !== $pos ) {
         // Handle post_type=post|page|foo pages.
@@ -50 +51 @@
         $hook_args = substr( $menu_page[2], $pos + 1 );
         wp_parse_str( $hook_args, $hook_args );
+
         // Set the hook name to be the post type.
         if ( isset( $hook_args['post_type'] ) ) {
@@ -60 +62 @@
         $hook_name = basename( $menu_page[2], '.php' );
     }
+
     $hook_name = sanitize_title( $hook_name );
 
@@ -99 +102 @@
         continue;
     }
+
     $subs       = $submenu[ $data[2] ];
     $first_sub  = reset( $subs );
     $old_parent = $data[2];
     $new_parent = $first_sub[2];
+
     /*
      * If the first submenu is not the same as the assigned parent,
      * make the first submenu the new parent.
      */
-    if ( $new_parent != $old_parent ) {
+    if ( $new_parent !== $old_parent ) {
         $_wp_real_parent_file[ $old_parent ] = $new_parent;
-        $menu[ $id ][2]                      = $new_parent;
+
+        $menu[ $id ][2] = $new_parent;
 
         foreach ( $submenu[ $old_parent ] as $index => $data ) {
@@ -172 +178 @@
         $subs      = $submenu[ $data[2] ];
         $first_sub = reset( $subs );
-        if ( $data[2] == $first_sub[2] ) {
+
+        if ( $data[2] === $first_sub[2] ) {
             unset( $submenu[ $data[2] ] );
         }
@@ -218 +225 @@
     $last_order  = false;
     $items_count = count( $menu );
-    $i           = 0;
+
+    $i = 0;
 
     foreach ( $menu as $order => $top ) {
         $i++;
 
-        if ( 0 == $order ) { // Dashboard is always shown/single.
+        if ( 0 === $order ) { // Dashboard is always shown/single.
             $menu[0][4] = add_cssclass( 'menu-top-first', $top[4] );
             $last_order = 0;
@@ -230 +238 @@
 
         if ( str_starts_with( $top[2], 'separator' ) && false !== $last_order ) { // If separator.
-            $first_item             = true;
-            $classes                = $menu[ $last_order ][4];
+            $first_item = true;
+            $classes    = $menu[ $last_order ][4];
+
             $menu[ $last_order ][4] = add_cssclass( 'menu-top-last', $classes );
             continue;
@@ -237 +246 @@
 
         if ( $first_item ) {
-            $classes           = $menu[ $order ][4];
+            $first_item = false;
+            $classes    = $menu[ $order ][4];
+
             $menu[ $order ][4] = add_cssclass( 'menu-top-first', $classes );
-            $first_item        = false;
         }
 
         if ( $i === $items_count ) { // Last item.
-            $classes           = $menu[ $order ][4];
+            $classes = $menu[ $order ][4];
+
             $menu[ $order ][4] = add_cssclass( 'menu-top-last', $classes );
         }
@@ -273 +284 @@
 if ( apply_filters( 'custom_menu_order', false ) ) {
     $menu_order = array();
+
     foreach ( $menu as $menu_item ) {
         $menu_order[] = $menu_item[2];
     }
     unset( $menu_item );
+
     $default_menu_order = $menu_order;
 
@@ -291 +304 @@
      * @param array $menu_order An ordered array of menu items.
      */
-    $menu_order         = apply_filters( 'menu_order', $menu_order );
-    $menu_order         = array_flip( $menu_order );
+    $menu_order = apply_filters( 'menu_order', $menu_order );
+    $menu_order = array_flip( $menu_order );
+
     $default_menu_order = array_flip( $default_menu_order );
 
@@ -305 +319 @@
     function sort_menu( $a, $b ) {
         global $menu_order, $default_menu_order;
+
         $a = $a[2];
         $b = $b[2];
+
         if ( isset( $menu_order[ $a ] ) && ! isset( $menu_order[ $b ] ) ) {
             return -1;
@@ -312 +328 @@
             return 1;
         } elseif ( isset( $menu_order[ $a ] ) && isset( $menu_order[ $b ] ) ) {
-            if ( $menu_order[ $a ] == $menu_order[ $b ] ) {
+            if ( $menu_order[ $a ] === $menu_order[ $b ] ) {
                 return 0;
             }