Changeset 55874

Timestamp:

06/01/2023 03:12:16 PM (16 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp-admin/includes/update.php.

Includes minor code layout fixes for better readability.

Follow-up to [9441], [25540].

Props aristath, poena, afercia, SergeyBiryukov.
See #57839.

File:

• trunk/src/wp-admin/includes/update.php (modified) (23 diffs)

trunk/src/wp-admin/includes/update.php

@@ -16 +16 @@
 function get_preferred_from_update_core() {
     $updates = get_core_updates();
+
     if ( ! is_array( $updates ) ) {
         return false;
     }
+
     if ( empty( $updates ) ) {
         return (object) array( 'response' => 'latest' );
     }
+
     return $updates[0];
 }
@@ -35 +38 @@
  */
 function get_core_updates( $options = array() ) {
-    $options   = array_merge(
+    $options = array_merge(
         array(
             'available' => true,
@@ -42 +45 @@
         $options
     );
+
     $dismissed = get_site_option( 'dismissed_update_core' );
 
@@ -56 +60 @@
     $updates = $from_api->updates;
     $result  = array();
+
     foreach ( $updates as $update ) {
         if ( 'autoupdate' === $update->response ) {
@@ -73 +78 @@
         }
     }
+
     return $result;
 }
@@ -87 +93 @@
 function find_core_auto_update() {
     $updates = get_site_transient( 'update_core' );
+
     if ( ! $updates || empty( $updates->updates ) ) {
         return false;
@@ -95 +102 @@
     $auto_update = false;
     $upgrader    = new WP_Automatic_Updater();
+
     foreach ( $updates->updates as $update ) {
         if ( 'autoupdate' !== $update->response ) {
@@ -108 +116 @@
         }
     }
+
     return $auto_update;
 }
@@ -125 +134 @@
 
     $ssl = wp_http_supports( array( 'ssl' ) );
+
     if ( $ssl ) {
         $url = set_url_scheme( $url, 'https' );
@@ -134 +144 @@
 
     $response = wp_remote_get( $url, $options );
+
     if ( $ssl && is_wp_error( $response ) ) {
         trigger_error(
@@ -143 +154 @@
             headers_sent() || WP_DEBUG ? E_USER_WARNING : E_USER_NOTICE
         );
+
         $response = wp_remote_get( $http_url, $options );
     }
 
-    if ( is_wp_error( $response ) || 200 != wp_remote_retrieve_response_code( $response ) ) {
+    if ( is_wp_error( $response ) || 200 !== wp_remote_retrieve_response_code( $response ) ) {
         return false;
     }
@@ -171 +183 @@
     $dismissed = get_site_option( 'dismissed_update_core' );
     $dismissed[ $update->current . '|' . $update->locale ] = true;
+
     return update_site_option( 'dismissed_update_core', $dismissed );
 }
@@ -192 +205 @@
 
     unset( $dismissed[ $key ] );
+
     return update_site_option( 'dismissed_update_core', $dismissed );
 }
@@ -212 +226 @@
 
     $updates = $from_api->updates;
+
     foreach ( $updates as $update ) {
-        if ( $update->current == $version && $update->locale == $locale ) {
+        if ( $update->current === $version && $update->locale === $locale ) {
             return $update;
         }
     }
+
     return false;
 }
@@ -235 +251 @@
 
     $cur = get_preferred_from_update_core();
+
     if ( ! is_object( $cur ) ) {
         $cur = new stdClass();
@@ -336 +353 @@
 function update_right_now_message() {
     $theme_name = wp_get_theme();
+
     if ( current_user_can( 'switch_themes' ) ) {
         $theme_name = sprintf( '<a href="themes.php">%1$s</a>', $theme_name );
@@ -385 +403 @@
     $upgrade_plugins = array();
     $current         = get_site_transient( 'update_plugins' );
+
     foreach ( (array) $all_plugins as $plugin_file => $plugin_data ) {
         if ( isset( $current->response[ $plugin_file ] ) ) {
@@ -406 +425 @@
 
     $plugins = get_site_transient( 'update_plugins' );
+
     if ( isset( $plugins->response ) && is_array( $plugins->response ) ) {
         $plugins = array_keys( $plugins->response );
+
         foreach ( $plugins as $plugin_file ) {
             add_action( "after_plugin_row_{$plugin_file}", 'wp_plugin_update_row', 10, 2 );
@@ -425 +446 @@
 function wp_plugin_update_row( $file, $plugin_data ) {
     $current = get_site_transient( 'update_plugins' );
+
     if ( ! isset( $current->response[ $file ] ) ) {
         return false;
@@ -608 +630 @@
 
     $update_themes = array();
+
     foreach ( $current->response as $stylesheet => $data ) {
         $update_themes[ $stylesheet ]         = wp_get_theme( $stylesheet );
@@ -627 +650 @@
 
     $themes = get_site_transient( 'update_themes' );
+
     if ( isset( $themes->response ) && is_array( $themes->response ) ) {
         $themes = array_keys( $themes->response );
@@ -819 +843 @@
  *
  * @global int $upgrading
+ *
  * @return void|false
  */
@@ -825 +850 @@
     require ABSPATH . WPINC . '/version.php';
     global $upgrading;
+
     $nag = isset( $upgrading );
+
     if ( ! $nag ) {
         $failed = get_site_option( 'auto_core_update_failed' );