Changeset 55885

Timestamp:

06/06/2023 04:17:02 PM (17 months ago)

Author:

spacedmonkey

Message:

Themes: Replace file_exists checks with call to is_block_theme method in WP_Theme class.

In WP_Theme class, replace two calls to file_exists with a call to the method is_block_theme. This method is_block_theme does the same file exists check, but it then caches the result for improved performance.

Props nihar007, spacedmonkey, mukesh27, costdev, juzar.
Fixes #58405.

File:

• trunk/src/wp-includes/class-wp-theme.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-theme.php

@@ -363 +363 @@
             $theme_path     = $this->theme_root . '/' . $this->stylesheet;
 
-            if (
-                ! file_exists( $theme_path . '/templates/index.html' )
-                && ! file_exists( $theme_path . '/block-templates/index.html' ) // Deprecated path support since 5.9.0.
-                && ! file_exists( $theme_path . '/index.php' )
-            ) {
+            if ( ! $this->is_block_theme() && ! file_exists( $theme_path . '/index.php' ) ) {
                 $error_message = sprintf(
                     /* translators: 1: templates/index.html, 2: index.php, 3: Documentation URL, 4: Template, 5: style.css */
@@ -381 +377 @@
                     'theme',
                     array(
-                        'block_theme' => $this->is_block_theme(),
+                        'block_theme' => $this->block_theme,
                         'headers'     => $this->headers,
                         'errors'      => $this->errors,