Changeset 55910

Timestamp:

06/13/2023 11:44:14 AM (3 years ago)

Author:

spacedmonkey

Message:

Editor: Skip file_exist check for core blocks.

In register_block_type_from_metadata function, skip calling file_exists on core blocks. Core blocks are part of the codebase and will never not exist. Not calling this function is better for performance, as the file lookup can be expensive.

Props spacedmonkey, joemcgill.
Fixes #58385.

File:

• trunk/src/wp-includes/blocks.php (modified) (2 diffs)

trunk/src/wp-includes/blocks.php

@@ -327 +327 @@
                 $file_or_folder;
 
-        if ( ! file_exists( $metadata_file ) ) {
+        $is_core_block = str_starts_with( $file_or_folder, ABSPATH . WPINC );
+
+        if ( ! $is_core_block && ! file_exists( $metadata_file ) ) {
                 return false;
         }
@@ -333 +335 @@
         // Try to get metadata from the static cache for core blocks.
         $metadata = false;
-        if ( str_starts_with( $file_or_folder, ABSPATH . WPINC ) ) {
+        if ( $is_core_block ) {
                 $core_block_name = str_replace( ABSPATH . WPINC . '/blocks/', '', $file_or_folder );
                 if ( ! empty( $core_blocks_meta[ $core_block_name ] ) ) {