Changeset 55921 for trunk/src/wp-includes/taxonomy.php

Timestamp:

06/14/2023 11:49:36 PM (23 months ago)

Author:

peterwilsoncc

Message:

Taxonomy: Prevent deprecation notices clearing terms.

Prevents wp_set_object_terms() throwing a deprecation notice in PHP 8.1+ when passing an empty value as the second parameter to clear the terms.

Props audrasjb, chouby, costdev, jrf, peterwilsoncc, prashantbhivsane, sergeybiryukov.
Fixes #57923.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (2 diffs)

trunk/src/wp-includes/taxonomy.php

@@ -2738 +2738 @@
  * @param string|int|array $terms     A single term slug, single term ID, or array of either term slugs or IDs.
  *                                    Will replace all existing related terms in this taxonomy. Passing an
- *                                    empty value will remove all related terms.
+ *                                    empty array will remove all related terms.
  * @param string           $taxonomy  The context in which to relate the term to the object.
  * @param bool             $append    Optional. If false will delete difference of terms. Default false.
@@ -2752 +2752 @@
     }
 
-    if ( ! is_array( $terms ) ) {
+    if ( empty( $terms ) ) {
+        $terms = array();
+    } elseif ( ! is_array( $terms ) ) {
         $terms = array( $terms );
     }