Changeset 55924 for trunk/tests/phpunit/tests/term/getTagLink.php

Timestamp:

06/15/2023 03:23:25 AM (2 years ago)

Author:

peterwilsoncc

Message:

Tests/Build tools: Various term related test improvements.

Modifies the tests for get_tag_link(), get_term() and get_term_field() to:

• use shared fixtures as possible
• improves variable names
• add @covers annotation as required

Props peterwilsoncc, costdev.
See #57841.

File:

• trunk/tests/phpunit/tests/term/getTagLink.php (modified) (3 diffs)

trunk/tests/phpunit/tests/term/getTagLink.php

@@ -6 +6 @@
  */
 class Tests_Term_GetTagLink extends WP_UnitTestCase {
-    public function test_success() {
-        $t = self::factory()->term->create(
+    /**
+     * Tag ID.
+     *
+     * @var int
+     */
+    public static $tag_id;
+
+    /**
+     * Test taxonomy term ID.
+     *
+     * @var int
+     */
+    public static $term_id;
+
+    /**
+     * Set up shared fixtures.
+     *
+     * @param WP_UnitTest_Factory $factory
+     */
+    public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+        self::$tag_id = $factory->term->create(
             array(
                 'taxonomy' => 'post_tag',
-                'slug'     => 'term-slug',
+                'slug'     => 'test-tag',
             )
         );
 
-        $found    = get_tag_link( $t );
-        $expected = home_url( '?tag=term-slug' );
+        register_taxonomy( 'wptests_tax', 'post' );
+        self::$term_id = self::factory()->term->create(
+            array(
+                'taxonomy' => 'wptests_tax',
+                'slug'     => 'test-term',
+            )
+        );
+    }
+
+    /**
+     * Set up the test fixture.
+     */
+    public function set_up() {
+        parent::set_up();
+        // Required as taxonomies are reset between tests.
+        register_taxonomy( 'wptests_tax', 'post' );
+    }
+
+    public function test_success() {
+        $tag_id = self::$tag_id;
+
+        $found    = get_tag_link( $tag_id );
+        $expected = home_url( '?tag=test-tag' );
 
         $this->assertSame( $expected, $found );
@@ -24 +64 @@
      */
     public function test_should_return_link_for_term_from_another_taxonomy_on_primed_cache() {
-        register_taxonomy( 'wptests_tax', 'post' );
+        $term_id = self::$term_id;
 
-        $t = self::factory()->term->create(
-            array(
-                'taxonomy' => 'wptests_tax',
-                'slug'     => 'test-term',
-            )
-        );
+        $term = get_term( $term_id );
 
-        $term = get_term( $t );
-
-        $found    = get_tag_link( $t );
+        $found    = get_tag_link( $term_id );
         $expected = home_url( '?wptests_tax=test-term' );
 
@@ -45 +78 @@
      */
     public function test_should_return_link_for_term_from_another_taxonomy_on_empty_cache() {
-        register_taxonomy( 'wptests_tax', 'post' );
+        $term_id = self::$term_id;
 
-        $t = self::factory()->term->create(
-            array(
-                'taxonomy' => 'wptests_tax',
-                'slug'     => 'test-term',
-            )
-        );
+        clean_term_cache( $term_id );
 
-        clean_term_cache( $t );
-
-        $found    = get_tag_link( $t );
+        $found    = get_tag_link( $term_id );
         $expected = home_url( '?wptests_tax=test-term' );