Changeset 55949 for trunk/src/wp-admin/includes/meta-boxes.php

Timestamp:

06/20/2023 03:45:23 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Media: Display the “Copy URL” and “Download file” row actions when the “Unattached” filter is applied.

Due to partially duplicated logic for displaying row actions in the Media Library with and without the “Unattached” filter, the “Copy URL” and “Download file” row actions were unintentionally missing with the filter applied.

This commit aims to simplify the logic and bring more consistency to the code.

Includes displaying the “Download file” row action even when the “Trash” filter is applied, giving the user one more chance to download the media file before they delete it.

Follow-up to [8901], [13100], [16227], [16229], [52842], [55198], [55221].

Props kebbet, costdev, pbiron, oglekler, SergeyBiryukov.
Fixes #57890, #57893.

File:

• trunk/src/wp-admin/includes/meta-boxes.php (modified) (1 diff)

trunk/src/wp-admin/includes/meta-boxes.php

@@ -470 +470 @@
         if ( current_user_can( 'delete_post', $post->ID ) ) {
                 if ( EMPTY_TRASH_DAYS && MEDIA_TRASH ) {
-                        echo "<a class='submitdelete deletion' href='" . get_delete_post_link( $post->ID ) . "'>" . __( 'Move to Trash' ) . '</a>';
+                        printf(
+                                '<a class="submitdelete deletion" href="%1$s">%2$s</a>',
+                                get_delete_post_link( $post->ID ),
+                                __( 'Move to Trash' )
+                        );
                 } else {
-                        $delete_ays = ! MEDIA_TRASH ? " onclick='return showNotice.warn();'" : '';
-                        echo "<a class='submitdelete deletion'$delete_ays href='" . get_delete_post_link( $post->ID, '', true ) . "'>" . __( 'Delete permanently' ) . '</a>';
+                        $show_confirmation = ! MEDIA_TRASH ? " onclick='return showNotice.warn();'" : '';
+
+                        printf(
+                                '<a class="submitdelete deletion"%1$s href="%2$s">%3$s</a>',
+                                $show_confirmation,
+                                get_delete_post_link( $post->ID, '', true ),
+                                __( 'Delete permanently' )
+                        );
                 }
         }