Changeset 55954 for trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

Timestamp:

06/21/2023 01:52:16 AM (3 years ago)

Author:

joedolson

Message:

Administration: Make checkbox column clickable.

Change the label for .check-column inside list tables to a block filling the entire cell. Improves accessibility by increasing the target area for the control.

Props mitchoyoshitaka, lessbloat, sabernhardt, ogleker, tacoverdo, joostdevalk, karmatosed.

Fixes #21516.

File:

• trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -513 +513 @@
                 $checkbox_id = 'checkbox_' . md5( $theme->get( 'Name' ) );
                 ?>
-                <input type="checkbox" name="checked[]" value="<?php echo esc_attr( $theme->get_stylesheet() ); ?>" id="<?php echo $checkbox_id; ?>" />
-                <label class="screen-reader-text" for="<?php echo $checkbox_id; ?>" >
+                <label class="label-covers-full-cell" for="<?php echo $checkbox_id; ?>" >
+                        <span class="screen-reader-text">
                         <?php
                         printf(
@@ -522 +522 @@
                         );
                         ?>
+                        </span>
                 </label>
+                <input type="checkbox" name="checked[]" value="<?php echo esc_attr( $theme->get_stylesheet() ); ?>" id="<?php echo $checkbox_id; ?>" />
                 <?php
         }