Changeset 55954 for trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php

Timestamp:

06/21/2023 01:52:16 AM (16 months ago)

Author:

joedolson

Message:

Administration: Make checkbox column clickable.

Change the label for .check-column inside list tables to a block filling the entire cell. Improves accessibility by increasing the target area for the control.

Props mitchoyoshitaka, lessbloat, sabernhardt, ogleker, tacoverdo, joostdevalk, karmatosed.

Fixes #21516.

File:

• trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php

@@ -416 +416 @@
      */
     public function column_cb( $item ) {
-        return sprintf( '<input type="checkbox" name="request_id[]" value="%1$s" /><span class="spinner"></span>', esc_attr( $item->ID ) );
+        return sprintf(
+            '<label class="label-covers-full-cell" for="requester_%1$s"><span class="screen-reader-text">%2$s</span></label>' .
+            '<input type="checkbox" name="request_id[]" id="requester_%1$s" value="%1$s" /><span class="spinner"></span>',
+            esc_attr( $item->ID ),
+            /* translators: Hidden accessibility text. %s: Email address. */
+            sprintf( __( 'Select %s' ), $item->email )
+        );
     }