Changeset 55954 for trunk/src/wp-admin/update-core.php

Timestamp:

06/21/2023 01:52:16 AM (20 months ago)

Author:

joedolson

Message:

Administration: Make checkbox column clickable.

Change the label for .check-column inside list tables to a block filling the entire cell. Improves accessibility by increasing the target area for the control.

Props mitchoyoshitaka, lessbloat, sabernhardt, ogleker, tacoverdo, joostdevalk, karmatosed.

Fixes #21516.

File:

• trunk/src/wp-admin/update-core.php (modified) (2 diffs)

trunk/src/wp-admin/update-core.php

@@ -572 +572 @@
         <td class="check-column">
             <?php if ( $compatible_php ) : ?>
-                <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $plugin_file ); ?>" />
-                <label for="<?php echo $checkbox_id; ?>" class="screen-reader-text">
+                <label for="<?php echo $checkbox_id; ?>" class="label-covers-full-cell">
+                    <span class="screen-reader-text">
                     <?php
                     /* translators: Hidden accessibility text. %s: Plugin name. */
                     printf( __( 'Select %s' ), $plugin_data->Name );
                     ?>
+                    </span>
                 </label>
+                <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $plugin_file ); ?>" />
             <?php endif; ?>
         </td>
@@ -746 +748 @@
         <td class="check-column">
             <?php if ( $compatible_wp && $compatible_php ) : ?>
-                <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $stylesheet ); ?>" />
-                <label for="<?php echo $checkbox_id; ?>" class="screen-reader-text">
+                <label for="<?php echo $checkbox_id; ?>" class="label-covers-full-cell">
+                    <span class="screen-reader-text">
                     <?php
                     /* translators: Hidden accessibility text. %s: Theme name. */
                     printf( __( 'Select %s' ), $theme->display( 'Name' ) );
                     ?>
+                    </span>
                 </label>
+                <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $stylesheet ); ?>" />
             <?php endif; ?>
         </td>