Context Navigation

← Previous Changeset
Next Changeset →

Changeset 55960

Timestamp:

06/21/2023 07:56:06 AM (16 months ago)

Author:

audrasjb

Message:

Twenty Nineteen: Always set background color and foreground color together.

On the <body> element, as a best practice background color and text color should always be set together. This makes it easier to quickly understand the
underlying color scheme.

Props allancole, joyously, samful, sabernhardt, oglekler, ronakganatra, tb1909, ugyensupport.
Fixes #45916.

Location:

trunk/src/wp-content/themes/twentynineteen

Files:

: 4 edited

sass/elements/_elements.scss (modified) (1 diff)
sass/typography/_typography.scss (modified) (1 diff)
style-rtl.css (modified) (2 diffs)
style.css (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-content/themes/twentynineteen/sass/elements/_elements.scss

r54171	r55960
19	19	body {
20	20	background-color: $color__background-body;
	21	color: $color__text-main;
21	22	}
22	23

trunk/src/wp-content/themes/twentynineteen/sass/typography/_typography.scss

r46587	r55960
7	7	-webkit-font-smoothing: antialiased;
8	8	-moz-osx-font-smoothing: grayscale;
	9	background-color: $color__background-body;
9	10	color: $color__text-main;
10	11	@include font-family( $font__body );

trunk/src/wp-content/themes/twentynineteen/style-rtl.css

-                      r55476
+                      r55960
   -webkit-font-smoothing: antialiased;
   -moz-osx-font-smoothing: grayscale;
-  color: #111;
   font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
   font-weight: 400;
 …
 body {
   background-color: #fff;
+  color: #111;
+}

trunk/src/wp-content/themes/twentynineteen/style.css

-                      r55476
+                      r55960
   -webkit-font-smoothing: antialiased;
   -moz-osx-font-smoothing: grayscale;
-  color: #111;
   font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
   font-weight: 400;
 …
 body {
   background-color: #fff;
+  color: #111;
+}

Note: See TracChangeset for help on using the changeset viewer.

Trac UI Preferences

Make WordPress Core