Changeset 55974 for trunk/src/wp-admin/options-writing.php

Timestamp:

06/22/2023 12:30:41 AM (2 years ago)

Author:

joedolson

Message:

Administration: Hide password in options/writing.

Hide the password for the "Post via e-mail" settings in writing options. Use the same password hiding mechanisms in use elsewhere in core.

Props mastrup, denis-de-bernardy, ryan, brookedot, wojtek.szkutnik, dd32, sabreuse, sergeybiryukov, costdev, peterwilsoncc, zgrkaralar, clorith, renyot, sabernhardt, boniu91, ironprogrammer, bgoewert.
Fixes #9883.

File:

• trunk/src/wp-admin/options-writing.php (modified) (2 diffs)

trunk/src/wp-admin/options-writing.php

@@ -54 +54 @@
     '<p>' . __( '<a href="https://wordpress.org/support/forums/">Support forums</a>' ) . '</p>'
 );
+
+wp_enqueue_script( 'user-profile' );
 
 require_once ABSPATH . 'wp-admin/admin-header.php';
@@ -169 +171 @@
 <td><input name="mailserver_login" type="text" id="mailserver_login" value="<?php form_option( 'mailserver_login' ); ?>" class="regular-text ltr" /></td>
 </tr>
-<tr>
-<th scope="row"><label for="mailserver_pass"><?php _e( 'Password' ); ?></label></th>
-<td>
-<input name="mailserver_pass" type="text" id="mailserver_pass" value="<?php form_option( 'mailserver_pass' ); ?>" class="regular-text ltr" />
-</td>
+<tr class="mailserver-pass-wrap">
+    <th scope="row">
+        <label for="mailserver_pass">
+            <?php _e( 'Password' ); ?>
+        </label>
+    </th>
+    <td>
+        <input type="hidden" value=" " /><!-- #24364 workaround -->
+        <span class="wp-pwd">
+            <input type="text" name="mailserver_pass" id="mailserver_pass" class="regular-text ltr" autocomplete="off" data-reveal="1" data-pw="<?php echo esc_attr( get_option( 'mailserver_pass' ) ); ?>" />
+            <button type="button" class="button wp-hide-pw hide-if-no-js" data-toggle="0" data-start-masked="1" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
+                <span class="dashicons dashicons-visibility" aria-hidden="true"></span>
+            </button>
+        </span>
+    </td>
 </tr>
 <tr>