Make WordPress Core


Ignore:
Timestamp:
06/22/2023 02:34:56 PM (13 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-custom-image-header.php

    r55977 r55988  
    370370        if ( current_theme_supports( 'custom-header', 'default-text-color' ) ) {
    371371            $default_color = get_theme_support( 'custom-header', 'default-text-color' );
    372             if ( $default_color && false === strpos( $default_color, '#' ) ) {
     372            if ( $default_color && ! str_contains( $default_color, '#' ) ) {
    373373                $default_color = '#' . $default_color;
    374374            }
     
    769769            if ( current_theme_supports( 'custom-header', 'default-text-color' ) ) {
    770770                $default_color = get_theme_support( 'custom-header', 'default-text-color' );
    771                 if ( $default_color && false === strpos( $default_color, '#' ) ) {
     771                if ( $default_color && ! str_contains( $default_color, '#' ) ) {
    772772                    $default_color = '#' . $default_color;
    773773                }
     
    777777
    778778            $header_textcolor = display_header_text() ? get_header_textcolor() : get_theme_support( 'custom-header', 'default-text-color' );
    779             if ( $header_textcolor && false === strpos( $header_textcolor, '#' ) ) {
     779            if ( $header_textcolor && ! str_contains( $header_textcolor, '#' ) ) {
    780780                $header_textcolor = '#' . $header_textcolor;
    781781            }
Note: See TracChangeset for help on using the changeset viewer.