Changeset 55988 for trunk/src/wp-admin/includes/class-custom-image-header.php

Timestamp:

06/22/2023 02:34:56 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-admin/includes/class-custom-image-header.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-custom-image-header.php

@@ -370 +370 @@
                 if ( current_theme_supports( 'custom-header', 'default-text-color' ) ) {
                         $default_color = get_theme_support( 'custom-header', 'default-text-color' );
-                        if ( $default_color && false === strpos( $default_color, '#' ) ) {
+                        if ( $default_color && ! str_contains( $default_color, '#' ) ) {
                                 $default_color = '#' . $default_color;
                         }
@@ -769 +769 @@
                         if ( current_theme_supports( 'custom-header', 'default-text-color' ) ) {
                                 $default_color = get_theme_support( 'custom-header', 'default-text-color' );
-                                if ( $default_color && false === strpos( $default_color, '#' ) ) {
+                                if ( $default_color && ! str_contains( $default_color, '#' ) ) {
                                         $default_color = '#' . $default_color;
                                 }
@@ -777 +777 @@
 
                         $header_textcolor = display_header_text() ? get_header_textcolor() : get_theme_support( 'custom-header', 'default-text-color' );
-                        if ( $header_textcolor && false === strpos( $header_textcolor, '#' ) ) {
+                        if ( $header_textcolor && ! str_contains( $header_textcolor, '#' ) ) {
                                 $header_textcolor = '#' . $header_textcolor;
                         }