Changeset 55988 for trunk/src/wp-admin/includes/class-wp-automatic-updater.php

Timestamp:

06/22/2023 02:34:56 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-admin/includes/class-wp-automatic-updater.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-automatic-updater.php

@@ -583 +583 @@
         // Send debugging email to admin for all development installations.
         if ( ! empty( $this->update_results ) ) {
-            $development_version = false !== strpos( get_bloginfo( 'version' ), '-' );
+            $development_version = str_contains( get_bloginfo( 'version' ), '-' );
 
             /**
@@ -641 +641 @@
         // We should not try to perform a background update again until there is a successful one-click update performed by the user.
         $critical = false;
-        if ( 'disk_full' === $error_code || false !== strpos( $error_code, '__copy_dir' ) ) {
+        if ( 'disk_full' === $error_code || str_contains( $error_code, '__copy_dir' ) ) {
             $critical = true;
         } elseif ( 'rollback_was_required' === $error_code && is_wp_error( $result->get_error_data()->rollback ) ) {
@@ -647 +647 @@
             $critical        = true;
             $rollback_result = $result->get_error_data()->rollback;
-        } elseif ( false !== strpos( $error_code, 'do_rollback' ) ) {
+        } elseif ( str_contains( $error_code, 'do_rollback' ) ) {
             $critical = true;
         }