Changeset 55988 for trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

Timestamp:

06/22/2023 02:34:56 PM (15 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

@@ -333 +333 @@
 
         $checksums = get_core_checksums( $wp_version, 'en_US' );
-        $dev       = ( false !== strpos( $wp_version, '-' ) );
+        $dev       = ( str_contains( $wp_version, '-' ) );
         // Get the last stable version's files and test against that.
         if ( ! $checksums && $dev ) {
@@ -397 +397 @@
         require ABSPATH . WPINC . '/version.php'; // $wp_version; // x.y.z
         // Only for dev versions.
-        if ( false === strpos( $wp_version, '-' ) ) {
+        if ( ! str_contains( $wp_version, '-' ) ) {
             return false;
         }