Changeset 55988 for trunk/src/wp-admin/includes/plugin.php

Timestamp:

06/22/2023 02:34:56 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (2 diffs)

trunk/src/wp-admin/includes/plugin.php

@@ -103 +103 @@
     if ( ! $plugin_data['TextDomain'] ) {
         $plugin_slug = dirname( plugin_basename( $plugin_file ) );
-        if ( '.' !== $plugin_slug && false === strpos( $plugin_slug, '/' ) ) {
+        if ( '.' !== $plugin_slug && ! str_contains( $plugin_slug, '/' ) ) {
             $plugin_data['TextDomain'] = $plugin_slug;
         }
@@ -1936 +1936 @@
                 return $parent_page;
             } elseif ( empty( $typenow ) && $pagenow === $submenu_array[2]
-                && ( empty( $parent_file ) || false === strpos( $parent_file, '?' ) )
+                && ( empty( $parent_file ) || ! str_contains( $parent_file, '?' ) )
             ) {
                 $parent_file = $parent_page;