Changeset 55988 for trunk/src/wp-admin/includes/privacy-tools.php

Timestamp:

06/22/2023 02:34:56 PM (16 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-admin/includes/privacy-tools.php (modified) (1 diff)

trunk/src/wp-admin/includes/privacy-tools.php

@@ -276 +276 @@
             $value = $group_item_datum['value'];
             // If it looks like a link, make it a link.
-            if ( false === strpos( $value, ' ' ) && ( str_starts_with( $value, 'http://' ) || str_starts_with( $value, 'https://' ) ) ) {
+            if ( ! str_contains( $value, ' ' ) && ( str_starts_with( $value, 'http://' ) || str_starts_with( $value, 'https://' ) ) ) {
                 $value = '<a href="' . esc_url( $value ) . '">' . esc_html( $value ) . '</a>';
             }