Make WordPress Core


Ignore:
Timestamp:
06/22/2023 02:34:56 PM (12 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/update-core.php

    r55824 r55988  
    11411141    $mysql_version     = $wpdb->db_version();
    11421142    $old_wp_version    = $GLOBALS['wp_version']; // The version of WordPress we're updating from.
    1143     $development_build = ( false !== strpos( $old_wp_version . $wp_version, '-' ) ); // A dash in the version indicates a development release.
     1143    $development_build = ( str_contains( $old_wp_version . $wp_version, '-' ) ); // A dash in the version indicates a development release.
    11441144    $php_compat        = version_compare( $php_version, $required_php_version, '>=' );
    11451145
     
    17651765
    17661766    if ( file_exists( "{$directory}example.html" )
    1767         && false !== strpos( file_get_contents( "{$directory}example.html" ), '<title>Genericons</title>' )
     1767        && str_contains( file_get_contents( "{$directory}example.html" ), '<title>Genericons</title>' )
    17681768    ) {
    17691769        $files[] = "{$directory}example.html";
     
    17751775        static function( $dir ) {
    17761776            // Skip any node_modules directories.
    1777             return false === strpos( $dir, 'node_modules' );
     1777            return ! str_contains( $dir, 'node_modules' );
    17781778        }
    17791779    );
Note: See TracChangeset for help on using the changeset viewer.