Changeset 55988 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

06/22/2023 02:34:56 PM (18 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (3 diffs)

trunk/src/wp-admin/includes/upgrade.php

@@ -1843 +1843 @@
         $meta_keys = array();
         foreach ( array_merge( get_post_types(), get_taxonomies() ) as $name ) {
-            if ( false !== strpos( $name, '-' ) ) {
+            if ( str_contains( $name, '-' ) ) {
                 $meta_keys[] = 'edit_' . str_replace( '-', '_', $name ) . '_per_page';
             }
@@ -3248 +3248 @@
         if ( 'index.php' === $oldfile ) {
             $index = implode( '', file( "$oldpath/$oldfile" ) );
-            if ( strpos( $index, 'WP_USE_THEMES' ) !== false ) {
+            if ( str_contains( $index, 'WP_USE_THEMES' ) ) {
                 if ( ! copy( "$default_dir/$oldfile", "$site_dir/$newfile" ) ) {
                     return false;
@@ -3365 +3365 @@
         foreach ( $stylelines as $line ) {
             foreach ( $headers as $header => $value ) {
-                if ( strpos( $line, $header ) !== false ) {
+                if ( str_contains( $line, $header ) ) {
                     $line = $header . ' ' . $value;
                     break;