Make WordPress Core


Ignore:
Timestamp:
06/22/2023 02:34:56 PM (12 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/upgrade.php

    r55854 r55988  
    18431843        $meta_keys = array();
    18441844        foreach ( array_merge( get_post_types(), get_taxonomies() ) as $name ) {
    1845             if ( false !== strpos( $name, '-' ) ) {
     1845            if ( str_contains( $name, '-' ) ) {
    18461846                $meta_keys[] = 'edit_' . str_replace( '-', '_', $name ) . '_per_page';
    18471847            }
     
    32483248        if ( 'index.php' === $oldfile ) {
    32493249            $index = implode( '', file( "$oldpath/$oldfile" ) );
    3250             if ( strpos( $index, 'WP_USE_THEMES' ) !== false ) {
     3250            if ( str_contains( $index, 'WP_USE_THEMES' ) ) {
    32513251                if ( ! copy( "$default_dir/$oldfile", "$site_dir/$newfile" ) ) {
    32523252                    return false;
     
    33653365        foreach ( $stylelines as $line ) {
    33663366            foreach ( $headers as $header => $value ) {
    3367                 if ( strpos( $line, $header ) !== false ) {
     3367                if ( str_contains( $line, $header ) ) {
    33683368                    $line = $header . ' ' . $value;
    33693369                    break;
Note: See TracChangeset for help on using the changeset viewer.