Context Navigation

← Previous Change
Next Change →

themes.php

Timestamp:

06/22/2023 02:34:56 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

: 1 edited

trunk/src/wp-admin/network/themes.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-admin/network/themes.php

r55637	r55988
40	40	check_admin_referer( 'enable-theme_' . $_GET['theme'] );
41	41	WP_Theme::network_enable_theme( $_GET['theme'] );
42		if ( ~~false === strpo~~s( $referer, '/network/themes.php' ) ) {
	42	if ( ! str_contains( $referer, '/network/themes.php' ) ) {
43	43	wp_redirect( network_admin_url( 'themes.php?enabled=1' ) );
44	44	} else {

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 55988 for trunk/src/wp-admin/network/themes.php

Legend:

trunk/src/wp-admin/network/themes.php

Download in other formats: