Changeset 55988 for trunk/src/wp-admin/post.php

Timestamp:

06/22/2023 02:34:56 PM (22 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-admin/post.php (modified) (2 diffs)

trunk/src/wp-admin/post.php

@@ -56 +56 @@
 $sendback = wp_get_referer();
 if ( ! $sendback ||
-    false !== strpos( $sendback, 'post.php' ) ||
-    false !== strpos( $sendback, 'post-new.php' ) ) {
+    str_contains( $sendback, 'post.php' ) ||
+    str_contains( $sendback, 'post-new.php' ) ) {
     if ( 'attachment' === $post_type ) {
         $sendback = admin_url( 'upload.php' );
@@ -98 +98 @@
 
         // Wrap Quick Draft content in the Paragraph block.
-        if ( false === strpos( $_POST['content'], '<!-- wp:paragraph -->' ) ) {
+        if ( ! str_contains( $_POST['content'], '<!-- wp:paragraph -->' ) ) {
             $_POST['content'] = sprintf(
                 '<!-- wp:paragraph -->%s<!-- /wp:paragraph -->',