Make WordPress Core


Ignore:
Timestamp:
06/22/2023 02:34:56 PM (3 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-content/themes/twentyseventeen/template-parts/post/content-video.php

    r53308 r55988  
    4747
    4848                // Only get video from the content if a playlist isn't present.
    49         if ( false === strpos( $content, 'wp-playlist-script' ) ) {
     49        if ( ! str_contains( $content, 'wp-playlist-script' ) ) {
    5050                $video = get_media_embedded_in_content( $content, array( 'video', 'object', 'embed', 'iframe' ) );
    5151        }
Note: See TracChangeset for help on using the changeset viewer.