Make WordPress Core


Ignore:
Timestamp:
06/22/2023 02:34:56 PM (11 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/block-supports/duotone.php

    r55417 r55988  
    4949 */
    5050function wp_tinycolor_bound01( $n, $max ) {
    51     if ( 'string' === gettype( $n ) && false !== strpos( $n, '.' ) && 1 === (float) $n ) {
     51    if ( 'string' === gettype( $n ) && str_contains( $n, '.' ) && 1 === (float) $n ) {
    5252        $n = '100%';
    5353    }
     
    5656
    5757    // Automatically convert percentage into number.
    58     if ( 'string' === gettype( $n ) && false !== strpos( $n, '%' ) ) {
     58    if ( 'string' === gettype( $n ) && str_contains( $n, '%' ) ) {
    5959        $n = (int) ( $n * $max ) / 100;
    6060    }
Note: See TracChangeset for help on using the changeset viewer.