Changeset 55988 for trunk/src/wp-includes/class-wp-editor.php

Timestamp:

06/22/2023 02:34:56 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-includes/class-wp-editor.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-editor.php

@@ -107 +107 @@
 
         if ( self::$this_tinymce ) {
-            if ( false !== strpos( $editor_id, '[' ) ) {
+            if ( str_contains( $editor_id, '[' ) ) {
                 self::$this_tinymce = false;
                 _deprecated_argument( 'wp_editor()', '3.9.0', 'TinyMCE editor IDs cannot have brackets.' );
@@ -1485 +1485 @@
             }
 
-            if ( false !== strpos( $value, '&' ) ) {
+            if ( str_contains( $value, '&' ) ) {
                 $mce_translation[ $key ] = html_entity_decode( $value, ENT_QUOTES, 'UTF-8' );
             }