Changeset 55988 for trunk/src/wp-includes/class-wp-meta-query.php

Timestamp:

06/22/2023 02:34:56 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-includes/class-wp-meta-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-meta-query.php

@@ -375 +375 @@
          * be LEFT. Otherwise posts with no metadata will be excluded from results.
          */
-        if ( false !== strpos( $sql['join'], 'LEFT JOIN' ) ) {
+        if ( str_contains( $sql['join'], 'LEFT JOIN' ) ) {
             $sql['join'] = str_replace( 'INNER JOIN', 'LEFT JOIN', $sql['join'] );
         }