Changeset 55988 for trunk/src/wp-includes/ms-functions.php

Timestamp:

06/22/2023 02:34:56 PM (23 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-includes/ms-functions.php (modified) (2 diffs)

trunk/src/wp-includes/ms-functions.php

@@ -1993 +1993 @@
     foreach ( $site_exts as $ext ) {
         foreach ( $mimes as $ext_pattern => $mime ) {
-            if ( '' !== $ext && false !== strpos( $ext_pattern, $ext ) ) {
+            if ( '' !== $ext && str_contains( $ext_pattern, $ext ) ) {
                 $site_mimes[ $ext_pattern ] = $mime;
             }
@@ -2166 +2166 @@
  */
 function maybe_add_existing_user_to_blog() {
-    if ( false === strpos( $_SERVER['REQUEST_URI'], '/newbloguser/' ) ) {
+    if ( ! str_contains( $_SERVER['REQUEST_URI'], '/newbloguser/' ) ) {
         return;
     }