Changeset 55988 for trunk/src/wp-includes/revision.php

Timestamp:

06/22/2023 02:34:56 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-includes/revision.php (modified) (3 diffs)

trunk/src/wp-includes/revision.php

@@ -139 +139 @@
         // Grab the latest revision, but not an autosave.
         foreach ( $revisions as $revision ) {
-            if ( false !== strpos( $revision->post_name, "{$revision->post_parent}-revision" ) ) {
+            if ( str_contains( $revision->post_name, "{$revision->post_parent}-revision" ) ) {
                 $latest_revision = $revision;
                 break;
@@ -224 +224 @@
 
     for ( $i = 0; isset( $revisions[ $i ] ); $i++ ) {
-        if ( false !== strpos( $revisions[ $i ]->post_name, 'autosave' ) ) {
+        if ( str_contains( $revisions[ $i ]->post_name, 'autosave' ) ) {
             continue;
         }
@@ -314 +314 @@
     }
 
-    if ( false !== strpos( $post->post_name, "{$post->post_parent}-autosave" ) ) {
+    if ( str_contains( $post->post_name, "{$post->post_parent}-autosave" ) ) {
         return (int) $post->post_parent;
     }