Changeset 55988 for trunk/src/wp-includes/script-loader.php

Timestamp:

06/22/2023 02:34:56 PM (15 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-includes/script-loader.php (modified) (2 diffs)

trunk/src/wp-includes/script-loader.php

@@ -652 +652 @@
         require ABSPATH . WPINC . '/version.php';
 
-        $develop_src = false !== strpos( $wp_version, '-src' );
+        $develop_src = str_contains( $wp_version, '-src' );
 
         if ( ! defined( 'SCRIPT_DEBUG' ) ) {
@@ -1481 +1481 @@
 
     if ( ! defined( 'SCRIPT_DEBUG' ) ) {
-        define( 'SCRIPT_DEBUG', false !== strpos( $wp_version, '-src' ) );
+        define( 'SCRIPT_DEBUG', str_contains( $wp_version, '-src' ) );
     }