Changeset 55988 for trunk/src/wp-includes/user.php

Timestamp:

06/22/2023 02:34:56 PM (16 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_contains().

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987].

Props Soean, spacedmonkey, costdev, dingo_d, azaozz, mikeschroder, flixos90, peterwilsoncc, SergeyBiryukov.
Fixes #58206.

File:

• trunk/src/wp-includes/user.php (modified) (2 diffs)

trunk/src/wp-includes/user.php

@@ -1766 +1766 @@
     }
 
-    $prefixed = false !== strpos( $field, 'user_' );
+    $prefixed = str_contains( $field, 'user_' );
 
     if ( 'edit' === $context ) {
@@ -2990 +2990 @@
     $expiration_duration = apply_filters( 'password_reset_expiration', DAY_IN_SECONDS );
 
-    if ( false !== strpos( $user->user_activation_key, ':' ) ) {
+    if ( str_contains( $user->user_activation_key, ':' ) ) {
         list( $pass_request_time, $pass_key ) = explode( ':', $user->user_activation_key, 2 );
         $expiration_time                      = $pass_request_time + $expiration_duration;